Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the apps preloading to merge to an existing apps.json file if it exists #2262

Open
alexgg opened this issue May 7, 2021 · 0 comments · May be fixed by balena-io-modules/balena-preload#242

Comments

@alexgg
Copy link
Contributor

alexgg commented May 7, 2021

Until now OS images did not contain an apps.json file so the preloading always copied one in. The OS will create an apps.json state with the preloaded state, so the CLI preloading needs to merge into this file instead of replacing it.

About this issue tracker

The balena CLI (Command Line Interface) is a tool used to interact with the balena platform.
This GitHub issue tracker is used for bug reports and feature requests regarding the CLI
tool. General and troubleshooting questions (such as setting up your project to work with a
balenalib base image) are encouraged to be posted to the balena
forums
, which are monitored by balena's support team and where the
community can both contribute and benefit from the answers.

Please also check that this issue is not a duplicate. If there is another issue describing
the same problem or feature please add comments to the existing issue.

Thank you for your time and effort creating the issue report, and helping us improve
the balena CLI!


Expected Behavior

Please describe what you were expecting to happen. If applicable, please add links to
documentation you were following, or to projects that you were trying to push/build.

Actual Behavior

Please describe what actually happened instead:

  • Quoting logs and error message is useful. If possible, quote the full output of the
    CLI, not just the error message.
  • Please quote the full command line too. Sometimes users report that they were
    "pushing" or "building" a project, but there are several ways to do so and several
    possible "targets" such as balenaCloud, openBalena, local balenaOS device, etc.
    Examples:
balena push myApp
balena push 192.168.0.12
balena deploy myApp
balena deploy myApp --build
balena build . -a myApp
balena build . -A armv7hf -d raspberrypi3

Each of the above command lines executes different code behind the scenes, so quoting the
full command line is very helpful.

Running the CLI in debug mode (--debug flag or DEBUG=1 environment variable) may reveal
additional information. The --logs option reveals additional information for the commands:

balena build . --logs
balena deploy myApp --build --logs

Steps to Reproduce the Problem

This is the most important and helpful part of a bug report. If we cannot reproduce the
problem, it is difficult to tell what the fix should be, or whether code changes have
fixed it.

Specifications

  • balena CLI version: e.g. 1.2.3 (output of the "balena version -a" command)
  • Cloud backend: openBalena or balenaCloud? If unsure, it will be balenaCloud
  • Operating system version: e.g. Windows 10, Ubuntu 18.04, macOS 10.14.5
  • 32/64 bit OS and processor: e.g. 32-bit Windows on 64-bit Intel processor
  • Install method: npm or zip package or executable installer
  • If npm install, Node.js and npm version: e.g. Node v8.16.0 and npm v6.4.1

Additional References

If applicable, please add additional links to GitHub projects, forums.balena.io threads,
gist.github.com, Google Drive attachments, etc.

alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 7, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 7, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 24, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 24, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 25, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 25, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 25, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 25, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue May 26, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue Jun 2, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue Jun 2, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue Jun 3, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue Jun 4, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
alexgg added a commit to balena-io-modules/balena-preload that referenced this issue Jun 7, 2021
If the image we are preloading to contains an existing `apps.json` append
the preloaded app to it instead of overwriting it.

Fixes balena-io/balena-cli#2262

Change-type: patch
Signed-off-by: Alex Gonzalez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant