-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom dind image based on alpine #251
Conversation
Tested on my workstation:
|
@klutchell I just tested this PR combined with #252 it and it worked great, details on my workstation below in case they help. I noticed however that the final compressed image size while smaller is not that big of a difference, it's down to 96MB from 103MB so ~7-8%. I'm not complaining, i'll take any improvement we can find but since you mentioned we are not using most of the official docker tools I wonder why the difference is "so small"? Maybe @rahul-thakoor can help us further reduce the image? :D
|
@tmigone Thanks for helping to test! Most of the space is the docker binaries so we can't reduce it much further. The one potential benefit this brings is armv6 and armv7 support since docker stopped publishing those images at v19.03
But do we even want/need to support preload on 32-bit ARM devices? I know there is a use case for testbot, and some users are trying it, but that doesn't mean we need to support it when the official images don't. Will probably end up on a product call at some point. See this discussion: balena-io/balena-cli#2290 (comment) |
@balena-ci retest |
@balena-ci retest |
This allows us to continue supporting armv7 even though the official dind images stopped at docker v19. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
Currently the daemon will slow startup to print some warnings if we don't include this flag. Future releases will require this flag in order to start insecure mode at all. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
In sfdisk 2.35.2 both --json and --dump are exclusive args and cannot be used together. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
@balena-ci I self-certify! |
Support additional platforms like armv7 by building our own DinD image.
brainstorm discussions