You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once #1208 gets merged, we'll already be in a much better place that should allow easier contributions to rendition, but there are still some things to improve. This is just a list of things so we don't forget.
Switch from enzyme to react-testing-library as a more lightweight solution
Investigate an issue where storyshots stop running if an argument is null (see Alert for commented out null for example)
Add dark mode toggling again (see if we can use the built-in background switch for it)
Improve the typings in the tests. As a way to make the migration faster, I sprinkled a lot of anys around.
Investigate the tooltip props and understand why it doesn't work anywhere
Investigate Element and understand why if modified it breaks storybooks.
Investigate as props, probably to remove from docs since internal
Investigate forwardedAs props, probably to remove from docs since internal
Trim down documentation on some of the components in favor of better autodetection/simpler API. A couple that come to mind are the Terminal and JsonSchemaRenderer
Improve documentation and props displayed of the following components:
Flex
Heading
ButtonGroup
Link
Select
Investigate on how to remove webpack config from .storybook/main.js added to correctly load the JsonEditor used in JsonSchemaRendererPlayground. (can probably replace react-monaco-editorwith https://www.npmjs.com/package/@monaco-editor/react
The text was updated successfully, but these errors were encountered:
Once #1208 gets merged, we'll already be in a much better place that should allow easier contributions to rendition, but there are still some things to improve. This is just a list of things so we don't forget.
enzyme
toreact-testing-library
as a more lightweight solutionnull
(see Alert for commented out null for example)any
s around.Element
and understand why if modified it breaks storybooks.as
props, probably to remove from docs since internalforwardedAs
props, probably to remove from docs since internalTerminal
andJsonSchemaRenderer
.storybook/main.js
added to correctly load theJsonEditor
used inJsonSchemaRendererPlayground
. (can probably replacereact-monaco-editor
with https://www.npmjs.com/package/@monaco-editor/reactThe text was updated successfully, but these errors were encountered: