Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development improvements #1215

Open
16 tasks
sradevski opened this issue Nov 19, 2020 · 0 comments
Open
16 tasks

Development improvements #1215

sradevski opened this issue Nov 19, 2020 · 0 comments

Comments

@sradevski
Copy link
Contributor

sradevski commented Nov 19, 2020

Once #1208 gets merged, we'll already be in a much better place that should allow easier contributions to rendition, but there are still some things to improve. This is just a list of things so we don't forget.

  • Switch from enzyme to react-testing-library as a more lightweight solution
  • Investigate an issue where storyshots stop running if an argument is null (see Alert for commented out null for example)
  • Add dark mode toggling again (see if we can use the built-in background switch for it)
  • Improve the typings in the tests. As a way to make the migration faster, I sprinkled a lot of anys around.
  • Investigate the tooltip props and understand why it doesn't work anywhere
  • Investigate Element and understand why if modified it breaks storybooks.
  • Investigate as props, probably to remove from docs since internal
  • Investigate forwardedAs props, probably to remove from docs since internal
  • Trim down documentation on some of the components in favor of better autodetection/simpler API. A couple that come to mind are the Terminal and JsonSchemaRenderer
  • Improve documentation and props displayed of the following components:

    • Flex
    • Heading
    • ButtonGroup
    • Link
    • Select
  • Investigate on how to remove webpack config from .storybook/main.js added to correctly load the JsonEditor used in JsonSchemaRendererPlayground. (can probably replace react-monaco-editorwith https://www.npmjs.com/package/@monaco-editor/react
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant