Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated engine to 16, installed node-modules, ran tests #1660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zoobot
Copy link

@zoobot zoobot commented Oct 19, 2022

Test Suites: 22 passed, 22 total
Tests: 560 passed, 560 total
Snapshots: 308 passed, 308 total
Time: 19.182 s
Ran all test suites.

Change-type: patch

@zoobot zoobot requested a review from thgreasi October 19, 2022 19:49
@zoobot zoobot linked an issue Oct 19, 2022 that may be closed by this pull request
@thgreasi
Copy link
Contributor

Previously we have been marking such changes as major (eg in 1ea47cf), since otherwise npm i for users in old node versions would stop.
Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.
Let's also change the title to be in present tense like the rest of the commits, like: Drop support for node < 16

@zoobot
Copy link
Author

zoobot commented Oct 19, 2022

Since this already works with node16 and flowzone already was testing this against node 12-18, I would personally wait until we have any other major change to do and get the in together.

It's ok to mash unrelated PRs together?

Change-type: major
@thgreasi
Copy link
Contributor

thgreasi commented Oct 20, 2022

We do that only for majors @zoobot b/c customers have raised concerns at some point about doing majors too often making the packages look not mature enough or not well though beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to node 16 at least
2 participants