Add typings for all abstract sql fragments, fixing where necessary #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
| 'LessThanOrEqual', | ||
| from, | ||
| to, | ||
| ], | ||
| ...equality, | ||
| }, | ||
| }; | ||
| } satisfies Record<string, NativeFactTypes[string]>; |
There was a problem hiding this comment.
Can't this be satisfies NativeFactTypes; ?
There was a problem hiding this comment.
It could but that's not accurate to what it is, because it is not itself a NativeFactTypes but rather a dictionary of fragments of them, so I made the typing in such a way as to try to represent that difference
| 'ends with': (from: string, to: string) => ['Endswith', from, to], | ||
| contains: (from: string, to: string) => ['Contains', from, to], | ||
| 'starts with': (from, to): StartsWithNode => ['StartsWith', from, to], | ||
| 'ends with': (from, to): EndsWithNode => ['EndsWith', from, to], |
There was a problem hiding this comment.
And one doubt, why did EndsWith required the backwards compactible change having both Endswith & EndsWith but StartsWith doesn't?
There was a problem hiding this comment.
Because StartsWith had previously been done for a translation
otaviojacobi
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on balena-io-modules/abstract-sql-compiler#250