-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shrinkwrapped express to v4.21.1 #2889
Update shrinkwrapped express to v4.21.1 #2889
Conversation
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/11776647253 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/12049976304 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
@alexgg Could I possibly get a quick eye on this? :) |
hey @oskarwilliams pinging some of the CLI maintainers for review @thgreasi @myarmolinsky |
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/12049976304 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
Hi, thank you for the PR, and sorry for missing it! The first commit makes sense to me, could you please drop that second commit and rebase instead of having a merge commit and push again? Please also run |
b930e30
to
b7660f7
Compare
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/12165047589 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
Thank you very much @alexgg, @myarmolinsky I have hopefully done as asked! :) |
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/12165047589 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
I think some automatic test failed due to GitHub runner automated issues, can we retrigger the failed jobs? |
The failed |
Once this PR merges: #2893 |
Please go ahead and rebase again when you have a chance. As noted, I expect you should be able to drop the |
Change-type: patch
b7660f7
to
38e2925
Compare
Thanks @myarmolinsky, I have rebased and rerun dedupe |
A repository maintainer needs to approve this workflow run. https://github.com/balena-io/balena-cli/actions/runs/12177427637 Maintainers, please review all commits and react with 👍 to approve or 👎 to reject. Things to look for: GitHub Actions Security Cheat Sheet |
Thank you for your contribution! Apologies for the rocky road along the way, but we appreciate your perseverance! |
Change-type: patch
Update shrinkwrapped express to v4.21.1 to bump cookie version to 0.7.1 to resolve low vulnerability
Resolves: #2888
Change-type: patch
Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.
Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.
If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.
If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.
Thank you very much for your contribution!