Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed/Cancelled release does not contain tags #25

Open
20k-ultra opened this issue Oct 28, 2021 · 2 comments
Open

Failed/Cancelled release does not contain tags #25

20k-ultra opened this issue Oct 28, 2021 · 2 comments

Comments

@20k-ultra
Copy link
Contributor

20k-ultra commented Oct 28, 2021

The action uses --release-tag flag from the balena CLI which only sets tags if the release build completes. It would be useful to have tags added to failed or cancelled releases so we can see which release is from what commit by the action.

This issue is even more common if the github action is stopped which #24 mentions that the kill signal doesn't reach the CLI and stop the build so you could even get a completed build with no tags.

@20k-ultra
Copy link
Contributor Author

I think the biggest hurdle in solving this issue is that the build action won't return a release ID if we cancel or the build fails so the action has no way to know the release id it needs to add the tags to.

@20k-ultra
Copy link
Contributor Author

@thgreasi what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant