Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPM graceful-fs deprecation warnings #298

Closed
jviotti opened this issue Apr 12, 2016 · 6 comments
Closed

Fix NPM graceful-fs deprecation warnings #298

jviotti opened this issue Apr 12, 2016 · 6 comments
Labels
platform:all type:misc

Comments

@jviotti
Copy link
Contributor

jviotti commented Apr 12, 2016 

npm WARN deprecated [email protected]: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
@jviotti
Copy link
Contributor Author

jviotti commented Apr 12, 2016

ack results:

$ ack --noignore-dir=node_modules --json graceful\\\-fs\\\"\\\:
node_modules/electron-builder/node_modules/electron-packager-tf/node_modules/asar/node_modules/mksnapshot/node_modules/decompress-zip/package.json
41:    "graceful-fs": "^3.0.0",

node_modules/electron-builder/node_modules/electron-packager-tf/node_modules/asar/node_modules/mksnapshot/node_modules/fs-extra/package.json
44:    "graceful-fs": "^3.0.5",

node_modules/electron-builder/node_modules/fs-extra/package.json
39:    "graceful-fs": "^4.1.2",

node_modules/electron-builder/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/electron-builder/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/electron-builder/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/electron-builder/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/electron-builder/node_modules/read-package-json/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/electron-builder/node_modules/read-package-json/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/electron-builder/node_modules/read-package-json/package.json
22:    "graceful-fs": "^4.1.2"
29:    "graceful-fs": "^4.1.2"

node_modules/electron-mocha/node_modules/fs-extra/package.json
39:    "graceful-fs": "^4.1.2",

node_modules/electron-mocha/node_modules/mocha/node_modules/glob/package.json
20:    "graceful-fs": "~2.0.0",

node_modules/electron-packager/node_modules/asar/node_modules/mksnapshot/node_modules/decompress-zip/package.json
36:    "graceful-fs": "^4.1.3",

node_modules/electron-packager/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/electron-packager/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/electron-packager/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/electron-packager/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/electron-packager/node_modules/fs-extra/package.json
39:    "graceful-fs": "^4.1.2",

node_modules/electron-prebuilt/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/electron-prebuilt/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/electron-prebuilt/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/electron-prebuilt/node_modules/electron-download/node_modules/nugget/node_modules/pretty-bytes/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/gulp/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/gulp/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/gulp/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/gulp/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/gulp/node_modules/vinyl-fs/node_modules/glob-watcher/node_modules/gaze/node_modules/globule/node_modules/glob/package.json
20:    "graceful-fs": "~1.2.0",

node_modules/gulp/node_modules/vinyl-fs/package.json
24:    "graceful-fs": "^3.0.0",

node_modules/gulp/package.json
56:    "graceful-fs": "^3.0.0",

node_modules/gulp-jscs/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/gulp-jscs/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/gulp-jscs/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/gulp-jscs/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/gulp-jshint/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/gulp-jshint/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/gulp-jshint/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/gulp-jshint/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/gulp-sass/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/npm.json
41:    "graceful-fs": "~1.2.0",

node_modules/gulp-sass/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/normalize-package-data/test/fixtures/read-package-json.json
26:    "graceful-fs": "~1.1.8"

node_modules/gulp-sass/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/load-json-file/package.json
34:    "graceful-fs": "^4.1.2",

node_modules/gulp-sass/node_modules/gulp-util/node_modules/dateformat/node_modules/meow/node_modules/read-pkg-up/node_modules/read-pkg/node_modules/path-type/package.json
42:    "graceful-fs": "^4.1.2",

node_modules/gulp-sass/node_modules/node-sass/node_modules/gaze/node_modules/globule/node_modules/glob/package.json
16:    "graceful-fs": "~1.2.0",

node_modules/gulp-sass/node_modules/node-sass/node_modules/node-gyp/package.json
27:    "graceful-fs": "^4.1.2",

node_modules/resin-zip-image/node_modules/unzip2/node_modules/fstream/package.json
19:    "graceful-fs": "~3.0.2",

@jviotti
Copy link
Contributor Author

jviotti commented Apr 13, 2016

The culprit of these errors are dependencies, which are already up to date. Its their responsibility to update, which they will eventually, so safe to close this.

@jviotti jviotti closed this as completed Apr 13, 2016
@imrehg
Copy link
Contributor

imrehg commented Aug 3, 2016

@jviotti might not be this simple as the closing comment

Currently this is the affected dependency tree:

├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └── [email protected] 
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

Affected modules:

@jviotti
Copy link
Contributor Author

jviotti commented Aug 3, 2016 •
edited
Loading

Hi @imrehg ,

Thanks for the research on this ticket. We recently replaced unzip2 with yauzl (https://github.com/thejoshwolfe/yauzl), so I think we're good on that.

I'll definitely upgrade windosu once your issue gets addressed.

@imrehg
Copy link
Contributor

imrehg commented Aug 3, 2016

@jviotti actually suddenly I realized, I am being stupid - that dependency tree was from the resin-cli, so replied to the wrong repo :/ Thanks for your patience, and glad that it sort of applies as well.
Though it also means resin-cli needs an update to yauzl too...

@jviotti
Copy link
Contributor Author

jviotti commented Aug 3, 2016

Hi @imrehg ,

Though it also means resin-cli needs an update to yauzl too...

Yeah, unzip2 will go away once I upgrade etcher-image-write to the latest version in the resin-cli.

@MaxMood96 MaxMood96 mentioned this issue Aug 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform:all type:misc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imrehg @jviotti