Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿ a11y(accordion): accordion not accessible #1419

Open
1 task done
carolabes opened this issue Jun 11, 2024 · 4 comments · Fixed by #1450
Open
1 task done

♿ a11y(accordion): accordion not accessible #1419

carolabes opened this issue Jun 11, 2024 · 4 comments · Fixed by #1450
Assignees
@hirsch88
Labels
🐛 bug Something isn't working
Milestone
♿️ Accessibility

Comments

@carolabes
Copy link

Description of this issue

  • Accordion items are not accessible via keyboard.
  • Accordions are missing native properties
accordion

How to fix it

  • Add native functionality.
  • Use aria-expanded

Additional Information

Level A
https://www.w3.org/WAI/WCAG21/Understanding/keyboard.html

aria-expanded: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carolabes carolabes added the ✨ feature New feature or request label Jun 11, 2024
@hirsch88 hirsch88 added 🐛 bug Something isn't working and removed ✨ feature New feature or request labels Aug 8, 2024
@hirsch88 hirsch88 self-assigned this Aug 8, 2024
@m4rc0z m4rc0z self-assigned this Aug 23, 2024
@hirsch88
Copy link
Member

hirsch88 commented Sep 6, 2024

/cib

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Branch fix/issue-1419 created!

github-actions bot added a commit that referenced this issue Sep 6, 2024
@github-actions
Create PR for #1419
74b3929
@github-actions github-actions bot mentioned this issue Sep 6, 2024
Merged
hirsch88 added a commit that referenced this issue Sep 6, 2024
@github-actions @hirsch88
♿ a11y(accordion): accordion not accessible (#1450)
e2c48b0 
* Create PR for #1419

* chore: fix nx scripts

* fix(accordion): make it keyboard accessible

* fix(list): make accordion accessible to the keyboard

* chore: fix nx scripts

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
@carolabes
Copy link
Author

Screenreader won't read if the accordion icon is expanded or reduced.

@GinaBiondo-aperto
Copy link
Collaborator

This is related to the accordion variant of the bal-list

@hirsch88 hirsch88 added this to the ♿️ Accessibility milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirsch88 hirsch88

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
♿️ Accessibility
Development

Successfully merging a pull request may close this issue.

♿ a11y(accordion): accordion not accessible baloise/design-system
4 participants
@hirsch88 @m4rc0z @GinaBiondo-aperto @carolabes