Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Mister P Docs #715

Closed
NathanielF opened this issue Sep 3, 2023 · 4 comments
Closed

Adding Mister P Docs #715

NathanielF opened this issue Sep 3, 2023 · 4 comments
Labels
documentation

Comments

@NathanielF
Copy link
Contributor

I have an open ticket on the pymc examples page to demonstrate the technique of Multilevel Regression and post stratification, but while working on this I found that it's much simpler and probably recommended to implement in Bambi.

I can add an example documented here if you think that would fit?
@zwelitunyiswa
Copy link

zwelitunyiswa commented Sep 3, 2023 •
edited
Loading

@NathanielF this might be a good guide - https://marginaleffects.com/articles/mrp.html and would you to showcase the new predictions function

@NathanielF
Copy link
Contributor Author

Added a draft PR here: #716

I tried using those new functions but they broke for me with my Mr P model. Aside from that i think i have everything in there i wanted to say, but would appreciate any feedback you might have.

@GStechschulte
Copy link
Collaborator

Added a draft PR here: #716

I tried using those new functions but they broke for me with my Mr P model. Aside from that i think i have everything in there i wanted to say, but would appreciate any feedback you might have.

These issues are being resolved in PR #721

GStechschulte added a commit to GStechschulte/bambi that referenced this issue Sep 15, 2023
@GStechschulte
remove commits related to PR bambinos#715
3cf30f4
GStechschulte added a commit that referenced this issue Sep 18, 2023
@GStechschulte @NathanielF
interpret support group effects (#721)
ab54b99 
* [715] Adding Mr P docs

Signed-off-by: Nathaniel <[email protected]>

* [715] updating black formatting and suppressing numpyro messages

Signed-off-by: Nathaniel <[email protected]>

* [715] adding plot_comparisons checks on basic model

Signed-off-by: Nathaniel <[email protected]>

* remove Mr.P example and metadata

* support group-specific-effects default values and sampling from new groups

* use set with in for conditional statement

* remove commits related to PR #715

* add group specific effects for interpret plotting functions

---------

Signed-off-by: Nathaniel <[email protected]>
Co-authored-by: Nathaniel <[email protected]>
@tomicapretto
Copy link
Collaborator

Closed since #716

GStechschulte added a commit to GStechschulte/bambi that referenced this issue Oct 3, 2023
@GStechschulte @NathanielF
interpret support group effects (bambinos#721)
4bd0cce 
* [715] Adding Mr P docs

Signed-off-by: Nathaniel <[email protected]>

* [715] updating black formatting and suppressing numpyro messages

Signed-off-by: Nathaniel <[email protected]>

* [715] adding plot_comparisons checks on basic model

Signed-off-by: Nathaniel <[email protected]>

* remove Mr.P example and metadata

* support group-specific-effects default values and sampling from new groups

* use set with in for conditional statement

* remove commits related to PR bambinos#715

* add group specific effects for interpret plotting functions

---------

Signed-off-by: Nathaniel <[email protected]>
Co-authored-by: Nathaniel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NathanielF @tomicapretto @zwelitunyiswa @GStechschulte