Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validating webhook implementation for KafkaUser resource #1035

Open
panyuenlau opened this issue Aug 10, 2023 · 0 comments
Open

Add validating webhook implementation for KafkaUser resource #1035

panyuenlau opened this issue Aug 10, 2023 · 0 comments
Assignees
@panyuenlau
Labels
community enhancement New feature or request

Comments

@panyuenlau
Copy link
Member

Problem Statement

Currently there is no validations against KafkaUser resources Create/Update/Delete operations.

Proposed Solution

Add a webhook implementation to validate resource creation and update for the KafkaUser resource. Some of the scenarios that we should reject client requests:

  • Referenced KafkaCluster doesn’t exist in the K8s cluster

  • Referenced KafkaCluster is being deleted

  • When spec.TopicGrants is set:

    • But the referenced KafkaCluster doesn’t have ACL enabled
    • The referenced KafkaCluster has ACL enabled, but the TopicGrants[x].topicName refers to a non-existing topic in the Kafka cluster

Additional Context

WIP PR: #968, will take some time to finish up the PR
@panyuenlau panyuenlau added enhancement New feature or request community labels Aug 10, 2023
@panyuenlau panyuenlau self-assigned this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panyuenlau panyuenlau

Labels
community enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panyuenlau