Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy and Cruisecontrol are not having custom label config in the CRD. #945

Open
saishivau opened this issue Mar 10, 2023 · 3 comments · May be fixed by #951
Open

Envoy and Cruisecontrol are not having custom label config in the CRD. #945

saishivau opened this issue Mar 10, 2023 · 3 comments · May be fixed by #951
Labels
community enhancement New feature or request help wanted Extra attention is needed

Comments

@saishivau
Copy link

Is your feature request related to a problem? Please describe.

I am not able to add custom labels to envoy and cruisecontrol pods via CRO.

Describe the solution you'd like to see
CRD file itself doesnt have the labels config defined in it.
@saishivau saishivau changed the title Envoy and Cruisecontrol pods are not having custom label config in the CRD. Envoy and Cruisecontrol are not having custom label config in the CRD. Mar 10, 2023
@panyuenlau panyuenlau added the enhancement New feature or request label Mar 10, 2023
@panyuenlau
Copy link
Member

Hi @saishivau,

I did a quick check and indeed currently there is no way to add customized labels to the Envoy and CruiseControl pods. Would you mind helping us with this minor feature implementation?

The implementation should be straightforward and you can refer to how the implementation customized annotations for both Envoy and CruiseControl:

@panyuenlau panyuenlau added help wanted Extra attention is needed community labels Mar 10, 2023
@saishivau saishivau linked a pull request Mar 13, 2023 that will close this issue
Open
5 tasks
@saishivau
Copy link
Author

Hi @panyuenlau,
Can you please check the pull request. I didnt test the implementation because I am not able to test locally.

@panyuenlau
Copy link
Member

Hi @panyuenlau, Can you please check the pull request. I didnt test the implementation because I am not able to test locally.

@saishivau Left some comments in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Envoy and Cruisecontrol custom label addition saishivau/koperator
2 participants
@panyuenlau @saishivau