Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statefulset metadata label has invalid value (too long) #51

Open
mei-ling opened this issue Oct 1, 2020 · 1 comment
Open

Statefulset metadata label has invalid value (too long) #51

mei-ling opened this issue Oct 1, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mei-ling
Copy link

mei-ling commented Oct 1, 2020

Describe the bug

The name in the label seems to tag on the remote name:

Warning FailedCreate 14m (x730 over 8d) statefulset-controller create Pod thanos-sausw2-perf-compute-remote-sausw2-perf-compute-rule-0 in StatefulSet thanos-sausw2-perf-compute-remote-sausw2-perf-compute-rule failed error: Pod "thanos-sausw2-perf-compute-remote-sausw2-perf-compute-rule-0" is invalid: metadata.labels: Invalid value: "thanos-sausw2-perf-compute-remote-sausw2-perf-compute-rule-768cbbd9b8": must be no more than 63 characters

this is making it too long. it seems like you're taking these 3 lines to form the name:

Labels:
app.kubernetes.io/managed-by=thanos-sausw2-perf-general
app.kubernetes.io/name=rule
monitoring.banzaicloud.io/storeendpoint=remote-sausw2-perf-general

Steps to reproduce the issue:

Normal Thanos Operator deployment

Expected behavior
no repeats on the name making it unnecessarily long. make the metadata label name generation more graceful.

@mei-ling mei-ling changed the title Statefulset metadata label has invalid value Statefulset metadata label has invalid value (too long) Oct 1, 2020
@tarokkk tarokkk added the bug Something isn't working label Oct 2, 2020
@tarokkk
Copy link
Contributor

tarokkk commented Oct 2, 2020

Thank you we will review (and at least truncate long names)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants