You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Observe that the resultant store pods do not have a --max-time flag
Expected behavior
I'd expect the resultant store pods' Pod.spec.containers.args to have a --max-time=-24h argument.
Screenshots
Additional context
It's possible I've misunderstood the operator code, but it looks like this option does nothing, looking at this setArgs function. We either need to set the flags with reflection on a thanos struct tag, if this is not too awkward to do with the nested struct, or write code to handle this field.
The text was updated successfully, but these errors were encountered:
craigfurman
changed the title
store option "timeRanges" has no effect
Store option "timeRanges" has no effect
Nov 17, 2020
Describe the bug
Setting
Thanos.spec.storeGateway.timeRanges
, as documented in https://github.com/banzaicloud/thanos-operator/blob/master/docs/types/thanos_types.md, has no effect.Steps to reproduce the issue:
Upload the following manifests:
Observe that the resultant store pods do not have a
--max-time flag
Expected behavior
I'd expect the resultant store pods'
Pod.spec.containers.args
to have a--max-time=-24h
argument.Screenshots
Additional context
It's possible I've misunderstood the operator code, but it looks like this option does nothing, looking at this
setArgs
function. We either need to set the flags with reflection on athanos
struct tag, if this is not too awkward to do with the nested struct, or write code to handle this field.The text was updated successfully, but these errors were encountered: