-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HIS): add STMT his metric #74
base: wip/his-metrics
Are you sure you want to change the base?
Conversation
def9f87
to
91bfb45
Compare
Tested and it LGTM. |
be420a9
to
c3679fc
Compare
The merge-base changed after approval.
c1452fe
to
4a2edbb
Compare
Signed-off-by: Afonso Santos <[email protected]>
91bfb45
to
d68b295
Compare
Updated with the modifications introduced in #68 and changed the output format. |
I've tested this PR and it looks ok to me. However, I found that the tool counts any macro as a single statement, regardless of its contents. A function-like macro easily "hide" several statements from this tool. |
Yes, that's a big limitation from pmccabe. From its manual:
However, I didn't found any other tool that outputs number of statements per function as pmccabe does. I'll keep looking.
Didn't get this second point, could you share an example? |
This PR introduces the feature of checking the number of statements within each function.
Each function must only have a maximum of 50 statements.
The
pmccabe
tool is used to check this metric.Edited by @danielRep :
To test with https://github.com/bao-project/bao-his-tests just run the command
make ci METRIC=stmt
.Checklist: