Add component to comment with the database role #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffharcourt
force-pushed
the
db-role
branch
2 times, most recently
from
1d59fe3 to
f2efa0b
Compare
geoffharcourt
force-pushed
the
db-role
branch
2 times, most recently
from
5ddc50c to
3ec6a96
Compare
geoffharcourt
commented
Mar 27, 2021
gemfiles/5.2.gemfile
Outdated
| @@ -3,6 +3,6 @@ source "https://rubygems.org" | |||
| gem "mysql2", "~> 0.4.10" | |||
| gem "pg", "~> 0.15" | |||
| gem "sqlite3", "~> 1.3.6" | |||
| gem "rails", "= 5.2.2.1" | |||
| gem "rails", "= 5.2.5" | |||
There was a problem hiding this comment.
This is needed due to the mimemagic yank. It was easier to bump this here.
|
Any plans to resolve conflicts & merge this? |
geoffharcourt
force-pushed
the
db-role
branch
3 times, most recently
from
86ee543 to
5e2acd7
Compare
With multiple databases in Rails 6, it can be difficult to tell from logging if your database query is being made against the leader or follower database. This change adds a new component, `db_role`, which can be used with the database host and name to annotate the query with the current ActiveRecord role.
geoffharcourt
force-pushed
the
db-role
branch
from
5e2acd7 to
8e7998f
Compare
|
I rebased and tried to resolve conflicts since the PR was first opened, looks like there's some things that have drifted in the interim. |
|
Now that Marginalia's functionality has been made part of Rails 7, it doesn't seem likely that this PR is going to get merged. I'm going to close this out rather than plow more time into keeping it up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple databases in Rails 6, it can be difficult to tell from
logging if your database query is being made against the leader or
follower database. This change adds a new component,
db_role, whichcan be used with the database host and name to annotate the query with
the current ActiveRecord role.
Rubies prior to 2.5 are now EOLed and Rails 6 can't be installed on Ruby 2.4,so I've swapped out Rubies 2.2-2.4 for 2.5 and 2.6 in the build matrix.
Close #102
This change requires #105 to fix an unrelated failing test case.