Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Sidebar #824

Open
4 tasks
lowtorola opened this issue Sep 25, 2024 · 0 comments
Open
4 tasks

Collapsible Sidebar #824

lowtorola opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
module: frontend Related to the Siarnaq frontend module priority: p1 critical type: feature New feature or request, or quick non-essential bugfix

Comments

@lowtorola
Copy link
Contributor

lowtorola commented Sep 25, 2024

Currently, our new frontend's sidebar is not collapsible! This is quite inconvenient, especially on mobile devices. We should have a hamburger menu that opens/closes the sidebar (ideally with an animation). Below are some target goals for this endeavor:

  • Add hamburger menu to the top left of our header bar that opens/closes the sidebar (see lovely diagram)
  • Stash sidebar state in cookies so that users can choose to leave the sidebar closed 🍪
  • Add an animation to the sidebar transition (implementer's choice!)
  • Always default the sidebar to closed on mobile 🥇

To get started, check out our sidebar's source code in index.tsx! Then, when you've gotten a handle on how you might go about opening/closing it (hint: check out the collapsed prop 😃) you can try to make it toggle-able! Note that our Header.tsx component already has a hamburger menu that can open/close its own menu for mobile, so maybe think (and ask!) about how you could integrate the header and sidebar to work together (consider using a Context).

@lowtorola lowtorola added type: feature New feature or request, or quick non-essential bugfix priority: p1 critical module: frontend Related to the Siarnaq frontend module labels Sep 25, 2024
@lowtorola lowtorola added this to the Frontend2 Alpha milestone Sep 25, 2024
@nour-massri nour-massri self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: frontend Related to the Siarnaq frontend module priority: p1 critical type: feature New feature or request, or quick non-essential bugfix
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants