Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to provide an option for color fill in some graphs #820 #826

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

ElderOrb
Copy link
Collaborator

No description provided.

@dericed
Copy link
Member

dericed commented May 13, 2024

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

@ElderOrb
Copy link
Collaborator Author

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

@dericed
Copy link
Member

dericed commented Jun 22, 2024

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

Did you push this commit? Example?

@dericed
Copy link
Member

dericed commented Jun 22, 2024

Also in the right area, the plot labels are running out of the ui,

image

Could we reduce the space between these?

@ElderOrb
Copy link
Collaborator Author

@ElderOrb, looks great! Any way to fill between the plotted line and a fixed point. Like from YDIF to bottom of graph or YDIF to zero?

added possibility to use constant values, will it work?

Did you push this commit? Example?

yep, 3d1cfd0#diff-5af9fe2734d6e69a5899ebbfbbf102bb170b97f59e390fbbf0224be72cb42247R277

@ElderOrb
Copy link
Collaborator Author

Also in the right area, the plot labels are running out of the ui,

image Could we reduce the space between these?

like this?
image

@dericed
Copy link
Member

dericed commented Jun 23, 2024

I think reducing the spacing causes some labels to get cut off in the tiles.
image

@dericed
Copy link
Member

dericed commented Jun 23, 2024

image

The fill is being filled even in yet unplotted areas.

I'm using

    //Diffs
    { Group_VDiff,   Group_Diffs,          "V DIF",         "lavfi.signalstats.VDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkred",    1, "0;darkred;0.4" },
    { Group_UDiff,   Group_Diffs,          "U DIF",         "lavfi.signalstats.UDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkblue",   1, "0;darkblue;0.4" },
    { Group_YDiff,   Group_Diffs,          "Y DIF",         "lavfi.signalstats.YDIF",    5,   false,  DBL_MAX, DBL_MAX, ActiveFilter_Video_signalstats, "darkgreen",  1, "0;teal;0.4" },

@dericed
Copy link
Member

dericed commented Jun 23, 2024

Can you cherry-pick in 0fc12fa before any updates?

@dericed dericed mentioned this pull request Jul 5, 2024
@dericed
Copy link
Member

dericed commented Jul 5, 2024

In testing again and found this:

  • in preferences be sure that Tiled Center Row and Tiled Center Column are enabled
  • in graph make sure the visibility of Tiled Center Row and Tiled Center Column are disabled
  • open a file and let it graph
  • then in the graph, enable the visibility of Tiled Center Row and Tiled Center Column. But they won't appear

if you enable the Tiled Center Row and Tiled Center Column visibility before graphing, then they show as expected.

@dericed
Copy link
Member

dericed commented Jul 5, 2024

Ah, this is broken in main too, so not a regression of this PR.

@dericed dericed merged commit c1edfa0 into bavc:main Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants