SCIP: add two version of the libraries (with or without parallelism baked in). #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (scip) have been updated in this PR. Please review the changes. |
|
please add the @bazel-io skip_check unstable_url tag |
lperron
changed the title
mering
reviewed
Dec 3, 2024
mering
reviewed
Dec 4, 2024
mering
reviewed
Dec 4, 2024
mering
reviewed
Dec 4, 2024
mering
reviewed
Dec 4, 2024
mering
reviewed
Dec 4, 2024
…S to BUILD file; create one patch file per file modified
mering
previously approved these changes
Dec 4, 2024
mering
reviewed
Dec 4, 2024
bazel-io
dismissed
mering’s stale review
Require module maintainers' approval for newly pushed changes.
mering
reviewed
Dec 4, 2024
|
don't forget to add the @bazel-io skip_check unstable_url tag |
mering
reviewed
Dec 4, 2024
|
Hi, can you get it merged? |
|
@meteorcloudy could you PTAL? Thanks! |
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
|
@mering You can also leave a comment like this and the bot would add the label to this PR. |
meteorcloudy
added
the
presubmit-auto-run
|
Please take a look at the patch failure |
|
All done. Tests are successful. |
meteorcloudy
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks when running SCIP in a java env