Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #3331

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented Dec 5, 2024

Hello @UebelAndre, @illicitonion, @scentini, modules you maintain (rules_rust) have been updated in this PR. Please review the changes.

@UebelAndre
Copy link
Contributor

UebelAndre commented Dec 5, 2024

Relates to #3327 (comment) I still don't see any pull-requests of sorts for the extra modules. Support would be appreciated!

@fmeum @kormide maybe?

@illicitonion
Copy link
Contributor

Relates to #3327 (comment) I still don't see any pull-requests of sorts for the extra modules. Support would be appreciated!

We'd probably need to push a new tag to trigger PRs, right? Shall we cut 0.55.1?

@UebelAndre
Copy link
Contributor

UebelAndre commented Dec 5, 2024

Relates to #3327 (comment) I still don't see any pull-requests of sorts for the extra modules. Support would be appreciated!

We'd probably need to push a new tag to trigger PRs, right? Shall we cut 0.55.1?

I had deleted the old tag and re-pushed this one. Maybe there's some caching in the bcr publish infra? But it would be nice to get an informed opinion so I don't have to delete any more tags.

edit: "informed" meaning someone who has access to more logs than you and I might 😅

@fmeum
Copy link
Contributor

fmeum commented Dec 6, 2024

I don't know what's up. Recreating a tag is usually good enough.

@UebelAndre
Copy link
Contributor

Does anyone know where https://github.com/bazel-contrib/publish-to-bcr dumps it's logs? Where can I see what it's doing when creating the pull request?

@fmeum
Copy link
Contributor

fmeum commented Dec 6, 2024

All maintainers should receive an email if it fails. But I don't know whether there are any logs in case it doesn't fail.

@UebelAndre
Copy link
Contributor

This should be rejected in favor of #3359

@fmeum fmeum closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants