Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second and further file changes not detected on MacOS Mojave #173

Closed
aherrmann opened this issue Nov 16, 2018 · 4 comments
Closed

Second and further file changes not detected on MacOS Mojave #173

aherrmann opened this issue Nov 16, 2018 · 4 comments

Comments

@aherrmann
Copy link

aherrmann commented Nov 16, 2018

Possibly related to #139 and angular/angular#21770

I've tested this using bazel-watcher version 0.7.0 and 0.5.0, on MacOS Mojave.
As an example project I picked java-tutorial from https://github.com/bazelbuild/examples.git .
Checkout that repository, change into the java-tutorial directory and execute ibazel build //:ProjectRunner. Then open the files src/main/java/com/example/{Greeting.java,ProjectRunner.java} in an editor.

  • Enter an empty line into the first file and save.
    ibazel notices and rebuilds the target.
  • Enter a second empty line into the first file and save.
    ibazel does not notice the modification and does not rebuild the target.
    Any further edits to this file are not noticed.
  • Enter an empty line into the second file and save.
    ibazel notices and rebuilds the target.
  • Enter a second empty line into the second file and save.
    ibazel does not notice the modification and does not rebuild the target.
    Any further edits to this file are not noticed.

We have observed the issue on two separate MacOS Mojave machines. We have observed it with version 0.5.0 and 0.7.0. We have not seen an instance of ibazel working properly on MacOS.


Update: The issue was observed on MacOS Sierra (10.12.6) and Mojave (10.14).
The issue was not observed on Linux, bazel-watcher seems to be working fine on Linux.

@achew22
Copy link
Member

achew22 commented Nov 16, 2018

The real problem is that I don't have a Mac to debug with. Any ideas/information you have is a thing I would be very happy to help with, I just don't have a box to test on ☹️

@aherrmann
Copy link
Author

@achew22 FreeBSD might be a good alternative as a development platform. It also uses kqueue and you can run it in a VM. At a glance it seems like Bazel and fsnotify support FreeBSD.

@aherrmann
Copy link
Author

Awesome, thanks @dougkoch and @achew22 . I tested this on a Mojave machine and the issue seems to be fixed. 🎉

@achew22
Copy link
Member

achew22 commented Nov 28, 2018

Woohoo! I'm cutting a v0.8.0 release right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants