Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel compilation warnings mark the sync as "finished with some errors" #7041

Open
jdai8 opened this issue Nov 22, 2024 · 3 comments
Open

Bazel compilation warnings mark the sync as "finished with some errors" #7041

jdai8 opened this issue Nov 22, 2024 · 3 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin type: bug

Comments

@jdai8
Copy link
Contributor

jdai8 commented Nov 22, 2024

Description of the bug:

#6813 seems to change how the sync status is displayed if the build had warnings. This happens even with the "New sync view" turned off.

This is confusing for users because it seems like sync did not complete successfully, when it actually did. If this is intended behavior, I think it would be useful to have a setting to configure it.

Which category does this issue belong to?

Intellij

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run a sync where the build contains some compilation warnings. I reproduced this on an internal codebase but I think it should happen for any compilation warnings.

Before this change (and with it reverted):
image

After this change:
image

Which Intellij IDE are you using? Please provide the specific version.

IntelliJ 2024.3

What programming languages and tools are you using? Please provide specific versions.

Java, Kotlin

What Bazel plugin version are you using?

Built from source

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@jdai8 jdai8 added awaiting-maintainer Awaiting review from Bazel team on issues type: bug labels Nov 22, 2024
@github-actions github-actions bot added the product: IntelliJ IntelliJ plugin label Nov 22, 2024
@tpasternak tpasternak assigned LeFrosch and unassigned mai93 Nov 22, 2024
@tpasternak
Copy link
Collaborator

Thank you Jack. I think we will have to hotfix that cc @LeFrosch

@LeFrosch
Copy link
Collaborator

Indeed, thanks reporting this. I'll take a look as soon as I can.

@LeFrosch
Copy link
Collaborator

Just checked it out myself with a build from master. In my case compilation warnings do not trigger similar behaviour. Could you share the actual warnings from the bazel errors view or logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin type: bug
Projects
Status: Untriaged
Development

No branches or pull requests

4 participants