-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jetpack Compose example to CI #493
Conversation
487253a
to
d62d17c
Compare
cc @Bencodes who initially wrote the sample |
Ah. We've been release blocked because we all thought we'd mucked up our dev boxes. |
I'm not sure why |
d62d17c
to
65913d3
Compare
One of the issues raised here is fixed by #530. |
b17d33e
to
19c850a
Compare
19c850a
to
a828b32
Compare
Hey @Kernald - mind resolving this or rebasing against master, and we can look again and see what's going wrong? |
I'll rebase and update as necessary tomorrow or Monday and ping here once it's done! |
fd25c7b
to
5d454bf
Compare
68e2925
to
9afc6a3
Compare
@cgruber This is now rebased onto I also tried to update Compose to its latest (1.0.0-rc01) version, which starts failing locally (most likely due to bazelbuild/bazel#13553, not related to rules_kotlin afaik). |
Thanks, I'll have a look later this weekend/early next week! |
Superseded by #657 |
This PR shows a few issues with the Jetpack Compose example:
But also with the overall example structure. There seem to be a hook set-up on CI to use a release build of the rules, which obviously doesn't work when building locally. The problem is, when using the parent repo, specifying a
compiler_release
inkotlin_repositories
doesn't seem to work (not entirely sure why).While this might end up building on CI (edit: it doesn't) with the few changes here, it definitely does not build locally as Compose 1.0.0-alpha09 requires kotlinc 1.4.21, which there's no way to force with the current set-up locally - the default version is 1.4.20.