Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack Compose example to CI #493

Closed
wants to merge 7 commits into from

Conversation

Kernald
Copy link
Contributor

@Kernald Kernald commented Feb 23, 2021

This PR shows a few issues with the Jetpack Compose example:

  • It's not built on CI
  • It actually doesn't build.

But also with the overall example structure. There seem to be a hook set-up on CI to use a release build of the rules, which obviously doesn't work when building locally. The problem is, when using the parent repo, specifying a compiler_release in kotlin_repositories doesn't seem to work (not entirely sure why).

While this might end up building on CI (edit: it doesn't) with the few changes here, it definitely does not build locally as Compose 1.0.0-alpha09 requires kotlinc 1.4.21, which there's no way to force with the current set-up locally - the default version is 1.4.20.

@Kernald Kernald force-pushed the ci-jetpack-compose branch 3 times, most recently from 487253a to d62d17c Compare February 23, 2021 07:48
@Kernald
Copy link
Contributor Author

Kernald commented Feb 24, 2021

cc @Bencodes who initially wrote the sample

@restingbull
Copy link
Collaborator

Ah. We've been release blocked because we all thought we'd mucked up our dev boxes.

@Kernald
Copy link
Contributor Author

Kernald commented Feb 28, 2021

I'm not sure why jarjar_runner fails to run on CI, as it runs perfectly on my machine in the same context.

@Kernald Kernald force-pushed the ci-jetpack-compose branch from d62d17c to 65913d3 Compare March 21, 2021 23:29
@Kernald
Copy link
Contributor Author

Kernald commented Apr 20, 2021

One of the issues raised here is fixed by #530.

@Kernald Kernald force-pushed the ci-jetpack-compose branch 2 times, most recently from b17d33e to 19c850a Compare April 20, 2021 05:21
@Kernald Kernald force-pushed the ci-jetpack-compose branch from 19c850a to a828b32 Compare May 19, 2021 05:00
@cgruber cgruber added this to the Candidate 1.5 milestone Jun 4, 2021
@Bencodes Bencodes mentioned this pull request Jun 4, 2021
@cgruber
Copy link
Collaborator

cgruber commented Jul 10, 2021

Hey @Kernald - mind resolving this or rebasing against master, and we can look again and see what's going wrong?

@Kernald
Copy link
Contributor Author

Kernald commented Jul 10, 2021

I'll rebase and update as necessary tomorrow or Monday and ping here once it's done!

@Kernald Kernald force-pushed the ci-jetpack-compose branch from fd25c7b to 5d454bf Compare July 12, 2021 00:30
@Kernald Kernald force-pushed the ci-jetpack-compose branch from 68e2925 to 9afc6a3 Compare July 12, 2021 00:37
@Kernald
Copy link
Contributor Author

Kernald commented Jul 12, 2021

@cgruber This is now rebased onto master, with a bit of clean-up to make buildifier happy, and fails with the same error in CI (it builds just fine locally on my machine).

I also tried to update Compose to its latest (1.0.0-rc01) version, which starts failing locally (most likely due to bazelbuild/bazel#13553, not related to rules_kotlin afaik).

@Bencodes
Copy link
Collaborator

@Kernald I opened up a new PR with everything fixed over here #657

@Kernald
Copy link
Contributor Author

Kernald commented Jan 15, 2022

Thanks, I'll have a look later this weekend/early next week!

@restingbull
Copy link
Collaborator

Superseded by #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants