-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin 1.5 support #544
Kotlin 1.5 support #544
Conversation
e404009
to
c5609ee
Compare
e4a7519
to
719642e
Compare
dd591c3
to
c26007a
Compare
We are testing this in our repository and will report back. |
It would be great to get this merged first so that we can be sure that there are no compose related regressions #493 |
We encountered this in our repository while testing 1.5.x bazelbuild/bazel#13553 |
Another issue we found #549 |
@alexjlockwood also ran into something similar in a few of our targets. |
@Bencodes is bazelbuild/bazel#13553 blocking? |
@jeffzoch we found a way to work around that issue inside our codebase so probably not a blocker. |
@Bencodes Can you please describe what you did for your workaround? |
@nkoroste The workaround is documented in the |
As an FYI, I want to merge this, but I'm going to do a thing where I extract a copy of the builder and set it up separately as a 1.4-specific builder, then merge this in. @restingbull and I realized we are going to have to start segmenting the tooling so that we handle different kotlin versions a bit differently (initially with a big fat dupe with minor tweaks, later refactored into smaller deltas). But I'll merge this in, I just need to yoink out the other, first. (and then I'll have some hassle, probably, messing with 3rd party deps. Sigh). |
This PR includes:
rules_kotlin
using 1.5.10validate_kotlinc_options
to fail fast when the new IR Kotlinc compiler flags that are enabled by default in 1.5 are passed in.