Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.5 support #544

Closed
wants to merge 11 commits into from
Closed

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented May 24, 2021

This PR includes:

  • Support for Kotlin 1.5.x API and language levels
  • Compiles rules_kotlin using 1.5.10
  • Updates validate_kotlinc_options to fail fast when the new IR Kotlinc compiler flags that are enabled by default in 1.5 are passed in.

@Bencodes Bencodes force-pushed the kotlin-1.5-support branch from e404009 to c5609ee Compare June 3, 2021 02:47
@Bencodes Bencodes force-pushed the kotlin-1.5-support branch from e4a7519 to 719642e Compare June 3, 2021 03:31
@Bencodes Bencodes force-pushed the kotlin-1.5-support branch from dd591c3 to c26007a Compare June 3, 2021 04:45
@cgruber cgruber added this to the Candidate 1.5 milestone Jun 4, 2021
@Bencodes
Copy link
Collaborator Author

Bencodes commented Jun 4, 2021

We are testing this in our repository and will report back.

@Bencodes
Copy link
Collaborator Author

Bencodes commented Jun 4, 2021

It would be great to get this merged first so that we can be sure that there are no compose related regressions #493

@Bencodes
Copy link
Collaborator Author

Bencodes commented Jun 7, 2021

We encountered this in our repository while testing 1.5.x bazelbuild/bazel#13553

@nkoroste
Copy link
Collaborator

nkoroste commented Jun 8, 2021

Another issue we found #549

@Bencodes
Copy link
Collaborator Author

Bencodes commented Jun 8, 2021

Another issue we found #549

@alexjlockwood also ran into something similar in a few of our targets.

@jeffzoch
Copy link
Contributor

jeffzoch commented Jul 6, 2021

@Bencodes is bazelbuild/bazel#13553 blocking?

@Bencodes
Copy link
Collaborator Author

Bencodes commented Jul 6, 2021

@jeffzoch we found a way to work around that issue inside our codebase so probably not a blocker.

@nkoroste
Copy link
Collaborator

nkoroste commented Jul 8, 2021

@Bencodes Can you please describe what you did for your workaround?

@Bencodes
Copy link
Collaborator Author

Bencodes commented Jul 8, 2021

@nkoroste The workaround is documented in the bazel_issue_13553 repo that I created for the bug report Bencodes/bazel_issue_13553#1

@cgruber
Copy link
Collaborator

cgruber commented Jul 10, 2021

As an FYI, I want to merge this, but I'm going to do a thing where I extract a copy of the builder and set it up separately as a 1.4-specific builder, then merge this in. @restingbull and I realized we are going to have to start segmenting the tooling so that we handle different kotlin versions a bit differently (initially with a big fat dupe with minor tweaks, later refactored into smaller deltas). But I'll merge this in, I just need to yoink out the other, first. (and then I'll have some hassle, probably, messing with 3rd party deps. Sigh).

@cgruber cgruber self-assigned this Jul 10, 2021
@cgruber cgruber added component: common P0 status: BLOCKED Progress cannot proceed (see comment thread) type: enhancement New feature or request labels Jul 10, 2021
@restingbull restingbull mentioned this pull request Aug 30, 2021
@Kernald
Copy link
Contributor

Kernald commented Sep 4, 2021

@Bencodes this can probably be closed now that #577 has been merged?

@Bencodes Bencodes closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: common P0 status: BLOCKED Progress cannot proceed (see comment thread) type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants