Added bzlmod support to all extension rules. (#3037)

Additional Changes:
- The rules `rules_nodejs` for `rules_rust_wasm_bindgen` will no longer
tested and will be dropped unless bzlmod support is added for the
original `bazel_build_rules_nodejs` rules.
- `rules_rust_bindgen` updated default clang version to 17.0.3 to match
bzlmod available version.
- `rules_rust_prost` updated protobuf version to `v28.3`

Relates to:
- #2181

.bazelci/presubmit.yml

@@ -972,7 +972,11 @@ tasks:
     build_targets:
       - "//..."
     test_targets:
+      - "--"
       - "//..."
+      # TODO: https://github.com/bazelbuild/rules_rust/issues/3039
+      - "-//rules_js/test:hello_world_wasm_lib_test"
+      - "-//rules_js/test:hello_world_wasm_direct_test"
   extensions_wasm_bindgen_macos:
     platform: macos_arm64
     name: Extensions wasm-bindgen

docs/BUILD.bazel

@@ -220,13 +220,6 @@ stardoc(
     deps = ["@rules_rust_wasm_bindgen//rules_js:bzl_lib"],
 )
 
-stardoc(
-    name = "rust_wasm_bindgen_rules_nodejs",
-    out = "rust_wasm_bindgen_rules_nodejs.md",
-    input = "@rules_rust_wasm_bindgen//rules_nodejs:defs.bzl",
-    deps = ["@rules_rust_wasm_bindgen//rules_nodejs:bzl_lib"],
-)
-
 sh_binary(
     name = "update_docs",
     srcs = ["update_docs.sh"],

docs/src/rust_wasm_bindgen.md

@@ -4,6 +4,11 @@
 
 Bazel rules for generating wasm modules for Javascript using [wasm-bindgen][wb].
 
+## Rules
+
+- [rust_wasm_bindgen](#rust_wasm_bindgen)
+- [rust_wasm_bindgen_toolchain](#rust_wasm_bindgen_toolchain)
+
 ## Setup
 
 To begin using the `wasm-bindgen` rules, users can load the necessary dependencies
@@ -24,15 +29,15 @@ should avoid calling `rust_wasm_bindgen_register_toolchains` and instead use the
 [rust_wasm_bindgen_toolchain](#rust_wasm_bindgen_toolchain) rule to define their own
 toolchains to register in the workspace.
 
-### Interfacing with Javascript rules
+## Interfacing with Javascript rules
 
 While it's recommended for users to mantain their own , in the
 `@rules_rust_wasm_bindgen` package there exists interface sub-packages for various
-Javascript Bazel rules. E.g. `build_bazel_rules_nodejs` or `aspect_rules_js`. The
-rules defined there are a more convenient way to use `rust_wasm_bindgen` with the
-associated javascript rules due to the inclusion of additional providers. Each
-directory contains a `defs.bzl` file that defines the different variants of
-`rust_wasm_bindgen`. (e.g. `nodejs_rust_wasm_bindgen` for the `rules_nodejs` submodule).
+Javascript Bazel rules. E.g. `aspect_rules_js`. The rules defined there are a more
+convenient way to use `rust_wasm_bindgen` with the associated javascript rules due
+to the inclusion of additional providers. Each directory contains a `defs.bzl` file
+that defines the different variants of `rust_wasm_bindgen`. (e.g. `js_rust_wasm_bindgen`
+for the `rules_js` submodule).
 
 
 [wb]: https://github.com/rustwasm/wasm-bindgen

extensions/bindgen/.bazelignore

@@ -1,5 +1,5 @@
 examples
 bazel-out
 bazel-testlogs
-bazel-extensions
+bazel-bindgen
 bazel-bin

extensions/bindgen/.bazelrc

@@ -60,9 +60,8 @@ build --incompatible_merge_fixed_and_default_shell_env
 ## Bzlmod
 ###############################################################################
 
-# TODO: migrate all dependencies from WORKSPACE to MODULE.bazel
-# https://github.com/bazelbuild/rules_rust/issues/2181
-common --noenable_bzlmod --enable_workspace
+# A configuration for disabling bzlmod.
+common:no-bzlmod --noenable_bzlmod --enable_workspace
 
 # Disable the bzlmod lockfile, so we don't accidentally commit MODULE.bazel.lock
 common --lockfile_mode=off

extensions/bindgen/3rdparty/BUILD.zstd.bazel

@@ -0,0 +1,28 @@
+load("@rules_cc//cc:defs.bzl", "cc_library")
+
+package(default_visibility = ["//visibility:public"])
+
+cc_library(
+    name = "zstd",
+    srcs = glob([
+        "lib/common/*.c",
+        "lib/common/*.h",
+        "lib/compress/*.c",
+        "lib/compress/*.h",
+        "lib/decompress/*.c",
+        "lib/decompress/*.h",
+        "lib/decompress/*.S",
+        "lib/dictBuilder/*.c",
+        "lib/dictBuilder/*.h",
+    ]),
+    hdrs = [
+        "lib/zdict.h",
+        "lib/zstd.h",
+        "lib/zstd_errors.h",
+    ],
+    defines = [
+        "LLVM_ENABLE_ZSTD=1",
+        "ZSTD_MULTITHREAD",
+    ],
+    strip_include_prefix = "lib",
+)

extensions/bindgen/3rdparty/patches/README.md

@@ -2,24 +2,11 @@
 
 All patches pair with the versions of the referenced repositories defined in `@rules_rust_bindgen//:repositories.bzl`.
 
-## [llvm-project.cxx17](./llvm-project.cxx17.patch)
-
-The llvm-project requires a compiler that builds with at least C++14 but there's no configuration
-for this on the targets defined in the repo. This patch plumbs through flags for setting the C++
-version on targets to avoid any need for bazel configuration flags. If this patch causes issues
-for users with their current toolchain or toolchain definitions then simply defining the `llvm-raw`
-repository before loading `rust_bindgen_dependencies` should avoid this.
-
 ## [llvm-project.incompatible_disallow_empty_glob](./llvm-project.incompatible_disallow_empty_glob.patch)
 
 Uses of `glob` are updated to have `allow_empty = True` added so the llvm-project repo is compatible
 with consumers building with [--incompatible_disallow_empty_glob](https://bazel.build/reference/command-line-reference#flag--incompatible_disallow_empty_glob).
 
-Most of this patch is generated using the following regex and replace patterns. There are a handful
-of additional modifications for more extravagant globs.
+## [llvm-raw.incompatible_disallow_empty_glob](./llvm-raw.incompatible_disallow_empty_glob.patch)
 
-| regex | replace |
-| --- | --- |
-| `glob\(([\[\w\d_\-\*\/\.\],=\n\s"]+)\) \+` | `glob($1, allow_empty = True) +` |
-| `glob\(([\[\w\d_\-\*\/\.\],=\n\s"]+)\),` | `glob($1, allow_empty = True),` |
-| `(,[\s\n]+), ` | `$1` |
+Similar to the `llvm-project` variant but is used outside of bzlmod.