External path dependencies work #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
local-path-deps
branch
8 times, most recently
from
f51a001 to
8dbbaae
Compare
illicitonion
force-pushed
the
local-path-deps
branch
2 times, most recently
from
0860669 to
0e23fc0
Compare
This allows dependencies of kind path to work, both in the [dependencies] table and the [patches] table. The intention is that this is used for third-party code not first-party code.
illicitonion
force-pushed
the
local-path-deps
branch
from
0e23fc0 to
7b53a90
Compare
UebelAndre
requested changes
Dec 4, 2024
examples/crate_universe_local_path/lazy_static_1.5.0_copy/.github/workflows/rust.yml
Outdated
Show resolved
Hide resolved
Merged
UebelAndre
approved these changes
Dec 5, 2024
| @@ -46,7 +46,7 @@ pub(crate) struct Context { | |||
| /// A list of crates visible to this bazel module. | |||
| pub(crate) direct_dev_deps: BTreeSet<CrateId>, | |||
|
|
|||
| /// A list of [patch] entries from the Cargo.lock file which were not used in the resolve. | |||
| /// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve. | |||
There was a problem hiding this comment.
Suggested change
| /// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve. | |
| /// A list of `[patch]` entries from the Cargo.lock file which were not used in the resolve. |
| @@ -175,7 +175,7 @@ pub(crate) struct LockfileAnnotation { | |||
| /// A mapping of crates/packages to additional source (network location) information. | |||
| pub(crate) crates: BTreeMap<PackageId, SourceAnnotation>, | |||
|
|
|||
| /// A list of [patch] entries from the Cargo.lock file which were not used in the resolve. | |||
| /// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve. | |||
There was a problem hiding this comment.
Suggested change
| /// A list of `[patch]`` entries from the Cargo.lock file which were not used in the resolve. | |
| /// A list of `[patch]` entries from the Cargo.lock file which were not used in the resolve. |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dependencies of kind path to work, both in the
[dependencies] table and the [patches] table.
The intention is that this is used for third-party code not first-party
code.