Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace loaderUtils.parseQuery() with loaderUtils.getOptions() #27

Open
purplesyringa opened this issue Apr 21, 2017 · 3 comments
Open

Comments

@purplesyringa
Copy link

purplesyringa commented Apr 21, 2017

(node:2732) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.

As of WebPack 2, passing string to parseQuery() is deprecated. In the next major version of loader-utils it will be removed. So, what about changing

var query = utils.parseQuery(this.query);

to

var query = utils.getOptions(this);

PS. I am talking about ejs-render-loader. BTW, do you know that https://npmjs.com/package/ejs-render-loader links to ejs-compiled-loader?

@kbtz
Copy link

kbtz commented Apr 30, 2017

+1

@imachug I believe this another package was created to have less misleading name.

@bazilio91 I've been using this loader a lot in our company codebase. Would you mind to add me as a collaborator to make these minor fixes? Nonetheless I'll make a PRs soon you'll have time to merge/review it?

Thanks!

@axten
Copy link

axten commented Aug 5, 2017

any updates here?

@hetz
Copy link

hetz commented Jul 18, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants