Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Conjunctions Static #95

Open
bbatsche opened this issue Aug 15, 2023 · 0 comments
Open

Make Conjunctions Static #95

bbatsche opened this issue Aug 15, 2023 · 0 comments

Comments

@bbatsche
Copy link
Owner

bbatsche commented Aug 15, 2023

There is currently a not-insignificant amount of code dedicated to dynamic conjunctions. In reality though, I've grown to doubt it adds much utility to the API. I'm guessing over 95% of use cases would be covered by is()/does()/has()/should()/will(). Part of my theory was also that it could be helpful for non-English speakers, but the rest of the API is in English, so does it really add that much? And all this at the expense of code complexity and lack of clarity for return types.

  • Make concrete conjunction functions
    • Possibly in a trait just to keep them localized somewhere
  • Pull in the other examples I'd relegated to examples in the documentation
@bbatsche bbatsche added this to Verify Aug 15, 2023
@bbatsche bbatsche converted this from a draft issue Aug 15, 2023
@bbatsche bbatsche added this to the 4.0.0 milestone Aug 15, 2023
@bbatsche bbatsche moved this from Backlog to In progress in Verify Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

1 participant