Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for dbplyr 2.5.0 and handling of failing GetCapabilities requests #341

Merged
merged 11 commits into from
Jul 8, 2024

Conversation

ateucher
Copy link
Collaborator

@ateucher ateucher commented Jul 5, 2024

This is mostly changes in tests to deal with stricter behaviour from dbplyr 2.5.0, specifically with local functions called within the bdata predicate functions (e.g., WITHIN(), BBOX()).

Also a few more fixes related to #339; closes #339

@ateucher ateucher marked this pull request as ready for review July 5, 2024 19:39
@ateucher
Copy link
Collaborator Author

ateucher commented Jul 5, 2024

The failure on ubuntu-latest (release) appears to be spurious (random 502 error)

@ateucher ateucher changed the title Dbplyr-2.5-fixes Fixes for dbplyr 2.5.0 and handling of failing GetCapabilities requests Jul 5, 2024
Copy link
Collaborator

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one comment about the error message. Just wondering if we can give the user a few more bread crumbs. Thanks for doing this!

R/bcdc_options.R Outdated Show resolved Hide resolved
tests/testthat/test-options.R Show resolved Hide resolved
Co-authored-by: Sam Albers <[email protected]>
@ateucher ateucher merged commit f9ac851 into main Jul 8, 2024
7 checks passed
@ateucher ateucher deleted the dbplyr-2.5-fixes branch July 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in path_to_connection(): ! does not exist in current working directory
2 participants