AFNetworking 2.6 breaks Twitter Oauth

[kolpanic]

I just logged an issue (AFNetworking/AFNetworking/issues/2999) about AFNetworking 2.6 not percent-encoding slashes in the parameters. In particular, the oauth_callback parameter's slashes are left intact, so I get a 401 Unauthorized error from Twitter's API.

Is there any approach from within BDBOAuth1Manager you can think of to work around this issue in the meantime?

Thanks.

[bdbergeron]

Hi @kolpanic. I actually encountered this issue on Sunday while attempting to work through issue #35, but didn't have time to resolve it. From what I read in the release notes, it appears it was a conscious decision by the maintainers of AFNetworking to change the way percent encoding works to abide by a certain RFC:

This release migrates query parameter serialization to model AlamoFire and adhere to RFC standards. Note that / and ? are no longer encoded by default.

Unfortunately, this means it comes down to me to restore the previous encoding in this library. I'll do my best to make that happen later this evening. You're more than welcome to submit a PR if you beat me to it! 😃

[kolpanic]

@bdbergeron From my reading of the RFC, it's more of a suggestion than a requirement. However, they've chosen to follow it, so, thanks.

[kolpanic]

@bdbergeron If you can think of a better approach, feel free to ignore my PR.

[kolpanic]

@bdbergeron I just tried this fix with AFNetworking 2.5.4, and (predictably) it doesn't work. I'm not aware of a way to check the AFNetworking version at runtime, so you may have to require 2.6 going forward.

[bdbergeron]

I definitely plan on the next release (1.6.0) bumping the requirement for AFNetworking to 2.6.+. I've been sticking to the versioning convention of BDBOAuth1Manager 1.x.+ utilizing AFNetworking 2.x.+ as much as possible, just so that it's as clear to developers that AFNetworking changes might result in changes to this library.

[bdbergeron]

So it looks like @skj4sc solved this issue in a PR to a different fork of this project (toopher#2), so I just cherry-picked his fixes into here. Should be good to go with AFNetworking 2.6.+ as of commit f4288a8.