Skip to content

Commit

Permalink
add log_line_series for lwb (#59)
Browse files Browse the repository at this point in the history
* add log_line_series for lwb

* added test

* bump version

* tests fixed!
  • Loading branch information
josephsdavid authored Apr 22, 2022
1 parent dd58b5e commit 86aabbc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Lighthouse"
uuid = "ac2c24cd-07f0-4848-96b2-1b82c3ea0e59"
authors = ["Beacon Biosignals, Inc."]
version = "0.14.4"
version = "0.14.5"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
6 changes: 6 additions & 0 deletions src/learn.jl
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ function log_value!(logger::LearnLogger, field::AbstractString, value)
return value
end


function log_line_series!(logger::LearnLogger, field::AbstractString, series, series_labels)
@warn "`log_line_series!` not implemented for `LearnLogger`"
return nothing
end

"""
log_evaluation_row!(logger, field::AbstractString, metrics)
Expand Down
7 changes: 7 additions & 0 deletions test/logger.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,10 @@
end
end
end

@testset "`Generic datastructure logging`" begin
mktempdir() do logdir
logger = LearnLogger(logdir, "test_run")
@test isnothing(Lighthouse.log_line_series!(logger, "foo", 3, 2))
end
end

2 comments on commit 86aabbc

@hannahilea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/58979

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.14.5 -m "<description of version>" 86aabbc39ad0579f777ddeea54858e20844359c5
git push origin v0.14.5

Please sign in to comment.