Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing :start_date field on SubscriptionSchedule.phases() typespec #861

Closed
2 tasks done
s3cur3 opened this issue Oct 17, 2024 · 4 comments
Closed
2 tasks done

Missing :start_date field on SubscriptionSchedule.phases() typespec #861

s3cur3 opened this issue Oct 17, 2024 · 4 comments

Comments

@s3cur3
Copy link

s3cur3 commented Oct 17, 2024

Existing Issue or Pull Request Verification

  • Confirmed, no existing Issues or Pull Requests found related to my submission.

Package Version

3.2.0

Are you using the latest version?

  • Yes, I verified the issue is still present in the latest version.

Steps to Reproduce

Hi there! Thanks for a wonderful, massively valuable library. ☺️ As a result of doing way more work with scheduled subscriptions than any human should, I ran across a small issue:

The phases() type defined on the SubscriptionSchedule is missing the start_date field.

Code reference:

Stripe docs: https://docs.stripe.com/api/subscription_schedules/object#subscription_schedule_object-phases

Expected Result

The phases typespec should match Stripe's docs

Actual Result

It does not 🙃

@yordis
Copy link
Member

yordis commented Oct 17, 2024

If I get time to finish #853 then most things should be fixed 😭 😭 😭 😭

Unfortunately, some anti-patterns were made in the codegen

@s3cur3
Copy link
Author

s3cur3 commented Oct 17, 2024

Ah, understood!

Copy link

This issue has been automatically marked as "stale:discard". We are sorry that we haven't been able to prioritize it yet.
If this issue still relevant, please leave any comment if you have any new additional information that helps to solve this issue. We encourage you to create a pull request, if you can. We are happy to help you with that.

Copy link

github-actions bot commented Dec 2, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still relevant, feel free to re-open the issue. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants