Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llab config file needs some changes #148

Open
xtitter opened this issue Jul 27, 2015 · 6 comments
Open

llab config file needs some changes #148

xtitter opened this issue Jul 27, 2015 · 6 comments

Comments

@xtitter
Copy link
Member

xtitter commented Jul 27, 2015

  • it should be json/yaml, rather than .js -- don't want random things executing
  • it should be called llab-config.yaml or json

And, it really should sit in the root llab directory, sigh. Do we really need to have llab inside the content repo; why can't it be next to it?

@cycomachead
Copy link
Member

don't want random things executing

Yes, in theory, but the config file should provide a way to add additional onload functions, that way it's easy to extend llab. For example the Snap! "run" URL's should be in bjc-r's config file not in llab.

And, it really should sit in the root llab directory, sigh.

But then llab can't be properly extracted as a dependency...or it makes it really hard to work with git and do that. :/

@cycomachead
Copy link
Member

But I'm also for a JSON or better spec. I don't know what's best. I want to somehow be able to custom define functions. Maybe we allow the config file to specify an external resource to load.

@xtitter
Copy link
Member Author

xtitter commented Jul 27, 2015

Yeah, pointing to a curriuclum-specific js file would be fine to come up
with a standard way.

I realize no JSON for the config file -- we need comments in there. YAML.

On Sun, Jul 26, 2015 at 10:47 PM, Michael Ball [email protected]
wrote:

But I'm also for a JSON or better spec. I don't know what's best. I want
to somehow be able to custom define functions. Maybe we allow the config
file to specify an external resource to load.


Reply to this email directly or view it on GitHub
#148 (comment).

<-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><->
Nathaniel Titterton, Ph.D. [email protected]
Computer Science Education U.C. Berkeley, 329 Soda Hall

@cycomachead
Copy link
Member

I realize no JSON for the config file -- we need comments in there. YAML.

Good point. Basically we could support both. YAML gets put into JSON by the browser anyway.

@xtitter
Copy link
Member Author

xtitter commented Jul 27, 2015

Yeah, except we should hardcode something in loader, or used by the
builder, that finds/loads the config file. I just made a change to my
local loader.js to find 'llab-config.js', which I know I'm going to screw
up and commit somehow. hm.

On Sun, Jul 26, 2015 at 11:18 PM, Michael Ball [email protected]
wrote:

I realize no JSON for the config file -- we need comments in there. YAML.

Good point. Basically we could support both. YAML gets put into JSON by
the browser anyway.


Reply to this email directly or view it on GitHub
#148 (comment).

<-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><-><=><->
Nathaniel Titterton, Ph.D. [email protected]
Computer Science Education U.C. Berkeley, 329 Soda Hall

@cycomachead
Copy link
Member

Yeah, except we should hardcode something in loader, or used by the
builder, that finds/loads the config file. I just made a change to my
local loader.js to find 'llab-config.js', which I know I'm going to screw
up and commit somehow. hm.

Git branches!

And yeah, well in the browser, we could just try different URLs too...which is sketchy but can work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants