Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common Genbank Feature.Type values should be enumerated #351

Open
carreter opened this issue Sep 20, 2023 · 4 comments
Open

Common Genbank Feature.Type values should be enumerated #351

carreter opened this issue Sep 20, 2023 · 4 comments
Labels
easy A quick and easy fix! enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things stale

Comments

@carreter
Copy link
Collaborator

carreter commented Sep 20, 2023 •
edited
Loading

While reviewing @cachemoi 's #350 , I noticed they added an explicit check for the type of a genbank Feature when determining whether the given feature was a coding sequence (feature.Type == "CDS").

Perhaps it would be helpful to encode common feature types into an enum (type FeatureType string) in the genbank package.

Blocked by #339 .

EDIT: another test
@carreter carreter added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers easy A quick and easy fix! medium priority The default priority for a new issue. labels Sep 20, 2023
@carreter
Copy link
Collaborator Author

Testing to see if the new "blocked by" between issues works:

Blocked by #339 .

@github-actions
Copy link

github-actions bot commented Sep 23, 2023 •
edited
Loading

Status: Ready to merge ✔️

Issues blocking this PR:

This comment was automatically written by the Blocking Issues bot, and this PR will be monitored for further progress.

@github-actions github-actions bot added the blocked Waiting for another PR/issue to be merged/closed. label Sep 23, 2023
@carreter carreter added this to the v1.0 milestone Sep 23, 2023
@carreter carreter removed this from the v1.0 milestone Sep 23, 2023
@carreter carreter added low priority Would be nice to fix, but doesn't have to happen right now/there are more important things and removed medium priority The default priority for a new issue. labels Sep 23, 2023
@github-actions GitHub Actions
Copy link

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Nov 22, 2023
@github-actions github-actions bot removed blocked Waiting for another PR/issue to be merged/closed. stale labels Dec 7, 2023
@carreter carreter mentioned this issue Dec 20, 2023
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This issue has had no activity in the past 2 months. Marking as stale.

@github-actions github-actions bot added the stale label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy A quick and easy fix! enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low priority Would be nice to fix, but doesn't have to happen right now/there are more important things stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carreter