New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i-bem: trigger twice runs jquery-trigger #601

Open

baymer opened this issue Feb 3, 2015 · 3 comments

Labels

baymer commented Feb 3, 2015

И __base, и __self.trigger дважды вызывают вот тут:
https://github.com/bem/bem-bl/blame/dev/blocks-common/i-bem/i-bem.js#L193

вот это:
https://github.com/bem/bem-bl/blob/dev/blocks-common/i-jquery/__observable/i-jquery__observable.js#L167

Не совершается ли лишняя работа?

Contributor

deeonis commented Feb 25, 2015

@dfilatov боюсь, здесь не обойтись без твоего мнения. Посмотришь?

Member

dfilatov commented Feb 25, 2015

__base вызывает триггер из https://github.com/bem/bem-bl/blob/dev/blocks-common/i-jquery/__observable/i-jquery__observable.js#L167, __self.trigger(e, data); вызывает триггер на классе. В чем именно тут лишняя работа?

Contributor

deeonis commented Feb 25, 2015

deeonis added the need info label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment