Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling naming at root of bemrc #20

Open
Vittly opened this issue Mar 21, 2018 · 1 comment
Open

Fix handling naming at root of bemrc #20

Vittly opened this issue Mar 21, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@Vittly
Copy link
Collaborator

Vittly commented Mar 21, 2018

This works:

{
  levels: [
    { layer: 'desktop', naming: 'react' },
    { layer: 'common', naming: 'react' }
  ]
}

This does not:

{
  naming: 'react',
  levels: [
    { layer: 'desktop' },
    { layer: 'common' }
  ]
}
@Vittly Vittly added the bug Something isn't working label Mar 21, 2018
@Vittly
Copy link
Collaborator Author

Vittly commented Apr 2, 2018

Also does not work:

{
  levels: [
    { layer: 'common', naming: { /* naming-object */ } }
  ]
}

Because of this code. Need write something like

typeof object === 'string' ? presets[naming] : naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant