Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prcEditor isn't opening #17

Open
SinnohSquid opened this issue Jul 24, 2021 · 5 comments
Open

prcEditor isn't opening #17

SinnohSquid opened this issue Jul 24, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@SinnohSquid
Copy link

SinnohSquid commented Jul 24, 2021

I've got only the 3.0.3 runtimes and prcEditor.exe doesn't do anything when clicked?

screen recording

^ video evidence if I didn't explain the problem right

@benhall-7
Copy link
Owner

benhall-7 commented Jul 24, 2021

Thanks for filing this issue! To start, I'm assuming you've downloaded the latest version. Given that you uninstalled the pre-3.0 runtimes I won't have to check that the right version is running, but if you want to be extra careful you can double-check by doing

dotnet --version

To check if there's some sort of dependency issue, in the command line, run

dotnet prcEditor.dll

So basically the exe is just a wrapper program that calls dotnet and the dll together. But it will hide the output which makes calling the exe in the command line equally useful to just double-clicking it in the folder.

If we get an error there, you can report it back here and we can decide what the solution might be.

Other options:

  • Thinking ahead, if it turns out the issue is a dependency problem with the desktop tools, I can venture a quick guess as to how to fix it. I notice that in the prcEditor.runtimeconfig.json, it lists Microsoft.WindowsDesktop.App as being the exact version 3.0.0. I don't really get why they would include the minor version, but since your version is 3.0.3, it might be worth trying to just change the last 0 to a 3 and trying again.

  • Alternatively, since you have dotnet and the desktop-app dependencies, you should be able to build and run from the source code. If you want to do that, you can git clone this repository (or just download the zip), go into the main folder (containing all 3 projects) and run in the command line:

dotnet publish prcEditor -o builds/prcEditor

then try running the output (which will be located in a folder named "builds")

@benhall-7 benhall-7 added the bug Something isn't working label Jul 24, 2021
@benhall-7 benhall-7 changed the title prcEditor refuses to do anything prcEditor isn't opening Jul 24, 2021
@SinnohSquid
Copy link
Author

SinnohSquid commented Jul 26, 2021

So I installed .NET core SDK 3.0.103 and ran dotnet prcEditor.dll and I got it to open.
I think it was a simple case of needing the SDK and not just the runtimes.

though it still doesn't open when double clicking?

@benhall-7
Copy link
Owner

benhall-7 commented Jul 26, 2021

That's kind of baffling. For one, the SDK really shouldn't be required because in its compiled form, it should only require the runtimes. Sounds like there's maybe some sort of re-compilation going on when you run the command. A quick solution to let you double click without any more work is to just create a batch file like prcEditor.bat where the contents are just the command that managed to work:

dotnet prcEditor.dll

I think what's happening is a problem with the 32bit (x86) vs 64bit (x64) versions of the runtime and the program exe. I notice that in your paths, dotnet runtimes are in the Program Files (x86) folder, maybe you should try the x64 versions of the dotnet runtimes instead.

Either that, or we can use a build for x86 or AnyCPU. The configuration isn't specified in my automatic build setup, so I'm not sure if it built only for x64. I would figure the automatic setting is "Any CPU", which should work for either option, but can't be sure since it's been a while without messing with settings. Just in case, I pushed a commit to explicitly set this, and the release page should now have the AnyCPU version

@TheComet
Copy link

I'm getting the same issue. When viewing the event logs, I see this error:

Description: A .NET Core application failed.
Application: prcEditor.exe
Path: D:\ssbu-modding\tools\prcEditor\prcEditor.exe
Message: A fatal error occurred. The required library hostfxr.dll could not be found.
If this is a self-contained application, that library should exist in [D:\ssbu-modding\tools\prcEditor\].
If this is a framework-dependent application, install the runtime in the global location [C:\Program Files\dotnet] or use the DOTNET_ROOT environment variable to specify the runtime location or register the runtime location in [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x64\InstallLocation].

After some googling it seems that this DLL is something you have to ship with the application when deploying it? I'm not sure how to install it.

@WorstSaiko
Copy link

  1. Make sure you have .NET installed [https://dotnet.microsoft.com/en-us/download]
  2. Open prcEditor.runtimeconfig and change all "3.0" to your version of .NET
    Was able to open afterwards for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants