-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test build #144
fix test build #144
Conversation
cielavenir
commented
Aug 28, 2023
•
edited
Loading
edited
- 4d9d52d fixes macos, though 2.7 cannot be fixed due to package removal
- Now c55be81 enforces extension. https://github.com/benhoyt/scandir/actions/runs/5993519451/job/16254028573 had build failure but we did not notice without enforcing extension.
- Also 2.7 test has been recovered by using containers.
4d9d52d fixes macos, though 2.7 cannot be fixed due to package removal (Now how can I maintain my own projects...) |
Thanks for this! What do you think about trying to fix 2.7 at the same time, by separating out 2.7 into a separate job and using this technique? |
Does this (now fixed) bug affect Python 3.10.2? |
try --require-scandir-extension
bd6b5aa
to
c55be81
Compare
@bschollnick sorry what bug? |
Now c55be81 enforces extension. https://github.com/benhoyt/scandir/actions/runs/5993519451/job/16254028573 had build failure but we did not notice without enforcing extension. Now maybe it is better to exclude Windows pypy-2.7 from CI? |
@benhoyt Addressed |
The Mac OS reverting to python code, instead of the C code? I might of grabbed the wrong comment? |
we did not test if that even happened, though currently we can see it is using C. please note that you should use pip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate this, thanks! Just a few small changes requested, and I'm wondering if we can go back to an environment variable rather than using the (deprecated) --global-option
flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for these changes.