Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for camera frame OSD element #1833

Open
etracer65 opened this issue Dec 6, 2019 · 5 comments
Open

Add support for camera frame OSD element #1833

etracer65 opened this issue Dec 6, 2019 · 5 comments

Comments

@etracer65
Copy link
Member

Recording this so we don't forget to add support for betaflight/betaflight#9261

Needs to be a little more than a simple element. The preview will have to take into account the width/height that are supplied separately in the MSP_OSD_CONFIG message so that the "frame" can be rendered properly. Ideally we should also let the user modify the width/height and these are supplied back the flight controller in MSP_SET_OSD_CONFIG.

My ideal scenario is to add "resize handles" to the corners and let the user drag and resize the camera frame. This would then update the position and width/height as appropriate.

This is potentially an issue with large elements wrapping in the preview that may still need to be addressed from this incomplete PR: #1324

@stale
Copy link

stale bot commented Jan 6, 2020

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@asizon
Copy link
Member

asizon commented Apr 26, 2020

Can be closed by #1879

@asizon
Copy link
Member

asizon commented Apr 26, 2020

True @mikeller, we still need to enable frame resizing

@haslinghuis
Copy link
Member

Fixed in #1879

@haslinghuis
Copy link
Member

My ideal scenario is to add "resize handles" to the corners and let the user drag and resize the camera frame. This would then update the position and width/height as appropriate.

Reopening to add a mechanism for

The normal OSD element position is used for the top-left of the frame. New parameters are available for the width/height.

osd_camera_frame_width
osd_camera_frame_height

The width/height are added to the MSP_SET_CONFIG and MSP_SET_OSD_CONFIG MSP messages to support configuring the frame size in the Configurator.

@haslinghuis haslinghuis reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants