fix: remove newlines before input-prompt text #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general: added a way to control if a newline should be added after a tag or not. This is a dirty solution, but that's its only real drawback at the moment. v0.3.0 will ship with a decent rewrite of the HTML/CSS logic, so I am going to postpone implementing a better solution until then.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 11 11
Lines 571 571
=======================================
Hits 469 469
Misses 81 81
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for a bug that was introduced some time earlier and went unnoticed, because I ignored whitespace differences when inspecting the diffs between the
.goldenfiles.Other than messing up the alignment for code cells and code outputs it did not affect the functionality, so other tests did not catch that either. The HTML that was produced was still valid and included the necessary data.
Anyways, that's the fix. As the commit message says, it's a bit dirty and the whole
html.tagfeels a bit contrived at the moment. I am planning to replace it with a more elegant "tagger" soon; that should clean up the code nicely.