Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify tracy nil checks #4023

Open
sprunk opened this issue Dec 16, 2024 · 0 comments
Open

Verify tracy nil checks #4023

sprunk opened this issue Dec 16, 2024 · 0 comments
Labels
Pull Request Welcome We aren't planning to this ourselves yet but pull requests are welcome

Comments

@sprunk
Copy link
Collaborator

sprunk commented Dec 16, 2024

The if tracy then tracy.foo() end pattern exists in a bunch of places, e.g.

if tracy then tracy.ZoneBeginN("Json:Decode") end

But if tracy is disabled then the tracy.foo() is removed from code, so the if tracy check is redundant and just incurs a perf cost whether Tracy is present or not. Remove those checks.

@sprunk sprunk added the Pull Request Welcome We aren't planning to this ourselves yet but pull requests are welcome label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Welcome We aren't planning to this ourselves yet but pull requests are welcome
Projects
None yet
Development

No branches or pull requests

1 participant