Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature states are visible through the fog of war #1816

Open
lostsquirrel1 opened this issue Dec 13, 2024 · 4 comments
Open

Feature states are visible through the fog of war #1816

lostsquirrel1 opened this issue Dec 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@lostsquirrel1
Copy link
Collaborator

If a tree is reclaimed or a wreck created, all players can see this change, even if they have no visibly of that part of the map.

@lostsquirrel1 lostsquirrel1 added the bug Something isn't working label Dec 13, 2024
@sprunk
Copy link
Collaborator

sprunk commented Dec 13, 2024

Intended if a game sets the feature visibility modrule to do that:

/// feature visibility style: 0 - no LOS for features, 1 - gaia features visible
/// 2 - gaia/allied features visible, 3 - all features visible
int featureVisibility;

switch (modInfo.featureVisibility) {
case CModInfo::FEATURELOS_NONE:
default:
return losHandler->InLos(pos, argAllyTeam);
// these next two only make sense when Gaia is enabled
case CModInfo::FEATURELOS_GAIAONLY:
return (isGaia || losHandler->InLos(pos, argAllyTeam));
case CModInfo::FEATURELOS_GAIAALLIED:
return (isGaia || allyteam == argAllyTeam || losHandler->InLos(pos, argAllyTeam));
case CModInfo::FEATURELOS_ALL:
return true;
}

@lostsquirrel1
Copy link
Collaborator Author

lostsquirrel1 commented Dec 13, 2024

Is there a setting where Trees are visible on map, but out of LOS, but when reclaimed then they are still visible until you get LOS on them and find out that it has been reclaimed?

Like buildings ghosts in fow.

@sprunk
Copy link
Collaborator

sprunk commented Dec 13, 2024

There isn't, but I don't think doing this natively would be good - there's too much UX involved in things like tooltip or rightclickability (note how unit ghosts already fail in this regard). See the first paragraph of the user story at #644.

@sprunk
Copy link
Collaborator

sprunk commented Dec 13, 2024

Implementing native ghosts for features sounds fine to try it out though since #644 opens up a whole different can of worms and is generally hard to do (not even getting into the unit orders part). I just expect people to be unhappy with native ghosts to the extent it would evolve into a poorman's version of 644 over time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants