Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix dialyzer fails #298

Closed
jauggy opened this issue May 28, 2024 · 1 comment · Fixed by #304
Closed

Mix dialyzer fails #298

jauggy opened this issue May 28, 2024 · 1 comment · Fixed by #304

Comments

@jauggy
Copy link
Member

jauggy commented May 28, 2024

Test Steps

Run

mix dialyzer

This does typechecking. You will get this error:

lib/teiserver/helpers/oban_logger.ex:43:call
The function call will not succeed.

System.convert_time_unit(any(), :native, :milliseconds)

breaks the contract
(integer(), time_unit() | :native, time_unit() | :native) :: integer()

Looking at the valid units
https://hexdocs.pm/elixir/1.12/System.html#t:time_unit/0

I think it should be :millisecond not :milliseconds

@Beherith this is a file you have worked on recently so it would be good if you can investigate.

@StanczakDominik
Copy link
Collaborator

Addressed in #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants