Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Svelte 4 in peerDependencies #91

Open
wants to merge 158 commits into
base: master
Choose a base branch
from

Conversation

StephenGunn
Copy link

Fixes build issues caused by upgrading to svelte 4.

@antony
Copy link
Member

antony commented Nov 11, 2024

This is unfortunately a huge amount of changes with the title "update peer dependencies", and as such, is difficult to review and merge.

I would recommend in future, breaking down your PR into individual PRs which address a single concern, rather than bundling everything together. It's too risky to merge this as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.