Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PDP 404 #1648

Merged
Merged

Conversation

fikrikarim
Copy link
Member

What/Why?

This error was introduced when we tried to fix a stale issue when publishing changes. Instead of just removing the postfix, we commented out the whole block that handles PDP.

Testing

Run locally, go to PDP.

image

This error was introduced when we tried to fix stale issue when publishing changes
@fikrikarim fikrikarim requested a review from a team as a code owner November 18, 2024 07:23
Copy link

linear bot commented Nov 18, 2024

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:29am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 18, 2024 7:29am
catalyst-au ⬜️ Ignored (Inspect) Nov 18, 2024 7:29am
catalyst-soul ⬜️ Ignored (Inspect) Nov 18, 2024 7:29am
catalyst-uk ⬜️ Ignored (Inspect) Nov 18, 2024 7:29am
catalyst-unstable ⬜️ Ignored (Inspect) Nov 18, 2024 7:29am

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 8edf6d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fikrikarim fikrikarim added this pull request to the merge queue Nov 18, 2024
Merged via the queue into vibes/soul-with-makeswift with commit e67f72f Nov 18, 2024
9 checks passed
@fikrikarim fikrikarim deleted the fikri/eng-6798-fix-pdp-page-404 branch November 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants