Option to provide non translated strings in a fallback locale #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cc35708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@thebigrick is attempting to deploy a commit to the BigCommerce Platform Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
deini
reviewed
Nov 19, 2024
|
Looks good, can we add a changeset please? |
I just provided one. I opted for a minor change rather than a patch since I do not consider the previous behavior a bug. |
chanceaclark
approved these changes
Nov 21, 2024
We assume 'en' as the most complete language
chanceaclark
force-pushed
the
localization-fallback
branch
from
1a841f8 to
cc35708
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…#1672) Co-authored-by: Riccardo Tempesta (aka The BigRick) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
If a new string is added, the translation must be available in any language. If not, the dotted path notation will be displayed in its place. I introduced the capability of using a fallback language for the missing strings.
Testing
messages/en.jsonfileen