Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relate list of values with following list of units #94

Open
sellth opened this issue Jul 14, 2023 · 0 comments
Open

Relate list of values with following list of units #94

sellth opened this issue Jul 14, 2023 · 0 comments

Comments

@sellth
Copy link
Collaborator

sellth commented Jul 14, 2023

Prelude

We allow semicolon-separated lists of values in Characteristics, Parameter Value, and possibly Factor Value fields.

@attr.s(auto_attribs=True, frozen=True)
class Characteristics:
    """Representation of a ``Characteristics[*]`` cell."""

    #: Characteristics name
    name: str
    #: Characteristics value
    value: List[FreeTextOrTermRef]
    #: Characteristics unit
    unit: FreeTextOrTermRef

When (a list of) ontology references are present, the value attribute becomes (a list of) OntologyTermRef objects, integrating ontology information with the Characteristics* values. Units are modelled as a separate class attribute.

Issue

When filling a Characteristics* field with a semicolon-separated list of values, one can follow up with a semicolon-separated list of ontology references and a list of units, but in SODAR only the ontology references are properly linked to the respective values. Units are not.

grafik
MicrosoftTeams-image

Questions

  • How can we relate a list of units to these values?
  • Do we want to solve this in Altamisa or should SODAR link them when rendering samplesheets?

In any case the unit attribute would need to be changed to a List[].

summoning @mikkonie @mkuhring @holtgrewe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant