Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mocking/patching in tests #163

Open
gromdimon opened this issue Aug 9, 2024 · 0 comments
Open

Fix the mocking/patching in tests #163

gromdimon opened this issue Aug 9, 2024 · 0 comments
Labels
bug Something isn't working testing The issue regards tests.

Comments

@gromdimon
Copy link
Collaborator

Describe the bug
Currently some tests are skipped due to unfunctional mocking/patching. However, this test increase test coverage and should be included in the overall test suit.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any test with "pytest.mark.skip()"
  2. Comment out the pytest skip mark
  3. Run the test
  4. Encounter an error

Expected behavior
Patching should patch what it should patch.

Screenshots
N/A

Additional context
This tests are located in tests/criteria

@gromdimon gromdimon added bug Something isn't working testing The issue regards tests. labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing The issue regards tests.
Projects
None yet
Development

No branches or pull requests

1 participant