Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove row sorting hacks from test_isa_export_batch() #2034

Open
mikkonie opened this issue Oct 30, 2024 · 0 comments
Open

Remove row sorting hacks from test_isa_export_batch() #2034

mikkonie opened this issue Oct 30, 2024 · 0 comments
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)

Comments

@mikkonie
Copy link
Contributor

The row sorting hacks used in test_isa_export_batch() make it very confusing trying to debug export problems. It seems this has originally been made due to issues with some ISA-Tab test files.

These issues (if they still exist) should be dealt with in the test files themselves, instead of convoluting the test case. I must have been in a hurry when I made this.
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikkonie