Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression with Magic SAM annotations #702

Closed
mzur opened this issue Nov 21, 2023 · 0 comments · Fixed by #703
Closed

Regression with Magic SAM annotations #702

mzur opened this issue Nov 21, 2023 · 0 comments · Fixed by #703
Labels
bug

Comments

@mzur
Copy link
Member

mzur commented Nov 21, 2023 •
edited
Loading

When I create a new Magic SAM annotation, an error occurs (see below). This may be related to #634. @lehecht can you debug Magic SAM locally? Otherwise I will have a look at it later.

Uncaught TypeError: invalid 'instanceof' operand e.geom.GeometryCollection
    read https://biigle.de/assets/scripts/main.js?1700556661:2
    h6 https://biigle.de/assets/scripts/main.js?1700556661:2
    handleNewFeature https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/vendor/magic-sam/scripts/main.js?1700556694:2
    dispatchEvent https://biigle.de/vendor/magic-sam/scripts/main.js?1700556694:2
    value https://biigle.de/vendor/magic-sam/scripts/main.js?1700556694:2
    handleEvent https://biigle.de/vendor/magic-sam/scripts/main.js?1700556694:2
    handleMapBrowserEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
    dispatchEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    handlePointerUp_ https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
    dispatchEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    fireNativeEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    ent https://biigle.de/assets/scripts/main.js?1700556661:2
    eventHandler_ https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
    r3 https://biigle.de/assets/scripts/main.js?1700556661:2
    addEvents_ https://biigle.de/assets/scripts/main.js?1700556661:2
    addEvents_ https://biigle.de/assets/scripts/main.js?1700556661:2
    register_ https://biigle.de/assets/scripts/main.js?1700556661:2
    registerSources https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
    handlePointerDown_ https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
    dispatchEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    fireNativeEvent https://biigle.de/assets/scripts/main.js?1700556661:2
    Qet https://biigle.de/assets/scripts/main.js?1700556661:2
    eventHandler_ https://biigle.de/assets/scripts/main.js?1700556661:2
    e https://biigle.de/assets/scripts/main.js?1700556661:2
@mzur mzur added the bug label Nov 21, 2023
@mzur mzur moved this to High Priority in BIIGLE Roadmap Nov 21, 2023
mzur added a commit that referenced this issue Nov 21, 2023
@mzur
Fix regression with PolygonValidator and modules
81522a0 
The magic-sam module imports OpenLayers as well and the instanceof
check to determine if an object is a polygon dind't work with the
"module Polygon".

Resolves #702
@mzur mzur mentioned this issue Nov 21, 2023
Merged
@mzur mzur closed this as completed in #703 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
BIIGLE Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression with PolygonValidator and modules biigle/core
1 participant
@mzur